Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update contract with enumerable NFT #24

Merged
merged 3 commits into from
Dec 12, 2024
Merged

update contract with enumerable NFT #24

merged 3 commits into from
Dec 12, 2024

Conversation

peterjah
Copy link
Collaborator

@peterjah peterjah commented Dec 6, 2024

No description provided.

@damip
Copy link
Member

damip commented Dec 10, 2024

Migration idea: add a "owner_reindex(token_ids: Array)" function (not necessarily owner-only) that will create the missing owner index entries for a list of token IDs. It will also update the supply counter by incrementing it for every previously missing index entry. Ignore already existing index entries.

Then we can just create a script that sends batches of requests to update all token IDs. Note that we probably won't be able to update them all in one request because there are probably just too many domains to fit in the gas limits of a block.

Already updated tokens will be freely usable. Entries that have not been reindexed yet will still be usable for domain resolution and target changes, but any ownership change would result in a failed execution (because the attempt to delete the old owner from the index will fail).

I feel like this would minimize impact.

Of course it will need to be tested in sandbox before we move on to buildinet.

Copy link
Member

@damip damip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bien ouèj

@peterjah peterjah merged commit 5acd6d7 into main Dec 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants