-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DeWeb CLI docs #355
Conversation
@pivilartisant just a naive question: have you created a |
yess ideed ! is it worth adding it to the docs ? |
I would say yes so people have a little help at anytime. But I'm not a dev. So I'm not sure it's relevant. Let's wait for @thomas-senechal to review the doc. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I couldn't comment on lines that were not changed so here is a global comment of all the things I would change:
-
There are still some mentions of the
yaml
config file (for example line 33) -
--wallet_nickname
has been replaced by:
-w, --wallet <path> Path to the wallet file
-p, --password <password> Password for the wallet file
IMO we need to explain that ATM only yaml
format is supported and how to get it (redirect to MW doc https://docs.massa.net/docs/massaStation/massa-wallet/account-backup and tell to use backup as yaml)
- We need to explain the possibility to use the secret key in a better way and give the env variable name
SECRET_KEY
somewhere - Examples should be updated to reflect the wallet handle changes (for example, like 99 we use the
-w
of previous version) edit
command has been merged withupload
- Other commands we added such as
ls
andshow
can be ignored for now, but maybe we should rewrite a bit this section to only explain how to upload/edit a website and not how to delete and configure the CLI ? And so, have another section that gives details like the config file, all global options, etc ?
We are updating DeWeb CLI docs