Refetch output amount claim page #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
pivilartisant
approved these changes
Jun 12, 2024
Thykof
force-pushed
the
refetch-output-amount-claim-page
branch
from
e0defb1 to
cc3d165
Compare
pivilartisant
force-pushed
the
refetch-output-amount-claim-page
branch
from
cc3d165 to
6faa4a4
Compare
Instead of duplicating the hook I added an additional check in the useEffect which disables the refetch after an outputAmount has been found... tested on both sides and working |
peterjah
reviewed
Jun 19, 2024
pivilartisant
force-pushed
the
refetch-output-amount-claim-page
branch
from
c9da7c6 to
4e8d137
Compare
peterjah
pushed a commit
that referenced
this pull request
Jul 16, 2024
* claim page: refetch output amount * fix refresh automatically claim page on mode change * improve amount display * add refetch check * fix build * add sugar syntax --------- Co-authored-by: Phoebe Lartisant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe we can improve because the refetch is never turn off. But the claim button will disapear if user change tab or windows. To improve: duplicate useFetchBurnEvent, name it useFetchClaimEvent and adatpt the use effect that turn
enableRefetchto false.