Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue was that different worker processes had different value of "nonce", thus producing different ipscrub value for same IP.
Consider this nginx.conf:
interesting parts here are
accept_mutex on
andworker_processes 2
- these two options mean that nginx will start two worker processes, and they will accept connections by turn. For some reason, I also had to addreuseport
tolisten
for this to work, too.If you run nginx with above config and run curl in a loop, you would get output like this:
Probably that's not what you wanted :)
This commit fixes it by using shared memory.
As another benefit, nonce now also "survives" nginx reconfiguration events.