Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLEAN-93 | Implement Caching with react-query #26

Open
wants to merge 8 commits into
base: CLEAN-74/MVP-for-showcase
Choose a base branch
from
Open

CLEAN-93 | Implement Caching with react-query #26

wants to merge 8 commits into from

Conversation

PaoloLlenado
Copy link
Contributor

Tickets

Changes

  • Installed react-query
  • Implemented react-query to thank you, item selection, and item size pages.
    • This fixes the issue of the images and text loading on every page navigation because they are being queried every time
  • Added cache behavior where the item details do not update until the page is refreshed.
  • Possible in the future: Add skeleton loaders

Testing Instructions

  • Navigate between pages and the text or images should not flicker because they are cached

Screenshots

@PaoloLlenado PaoloLlenado requested a review from Mikmik28 January 23, 2025 04:50
@PaoloLlenado PaoloLlenado self-assigned this Jan 23, 2025
Mikmik28
Mikmik28 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Collaborator

@Mikmik28 Mikmik28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-query ftw 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mikmik28 Mikmik28 Mikmik28 approved these changes

Assignees

@PaoloLlenado PaoloLlenado

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PaoloLlenado @Mikmik28