Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sd Squad 2 Task 3 Expandable text field #234

Open
wants to merge 4 commits into
base: sd-squad-2
Choose a base branch
from

Conversation

Jagbir-Singh-01
Copy link

@Jagbir-Singh-01 Jagbir-Singh-01 commented Feb 4, 2025

Description

Provide a concise summary of the changes in this PR. Include the motivation behind these changes and any relevant context.

Related Issue

If this PR addresses an issue, link to it here.

Type of Change

Please select the type(s) of change that apply and delete those that do not.

  • Bug fix: A non-breaking change that fixes an issue.
  • New feature: A non-breaking change that adds functionality.
  • Breaking change: A change that causes existing functionality to not work as expected.
  • Documentation update: Changes or updates to documentation.
  • Code style update: Changes that do not affect the meaning of the code (e.g., formatting).
  • Refactoring: A code change that neither fixes a bug nor adds a feature.
  • Performance improvement: A change that improves performance.
  • Test enhancement: Adding or updating tests; no production code change.
  • Chore: Changes to the build process or auxiliary tools; no production code change.
  • Other: (please describe)

Proposed Solution

Describe your code changes in detail. Explain how you implemented your solution and any design decisions you made.

How to Test

Provide instructions on how to test these changes. Include details on test configurations, test cases, and expected outcomes.

Unit Tests

List the unit tests added or modified to verify your changes.

Documentation Updates

Indicate whether documentation needs to be updated due to this PR.

  • Yes
  • No

If yes, describe what documentation updates are needed and link to the relevant documentation.

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

Additional Information

Add any other information that might be useful for the reviewers.

@Jagbir-Singh-01
Copy link
Author

Sd squad 2 task 3

@richiectr360 richiectr360 self-assigned this Feb 10, 2025
@richiectr360
Copy link

@Jagbir-Singh-01 Thank you for your work. These are my reviews.

1.The input starts as a single-line field and expands dynamically with user input. - ✅
2.Implement a maximum height limit after which the field becomes scrollable. - ✅
3.Ensure the CTA (send button) remains fixed when the input expands - ✅
4.Maintain a locked state while AI is generating responses, preventing premature input - ✅
5.Add a loading indicator when AI is processing. - ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants