Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Next.js from Version 12.3 to 13.5 #216

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Warrenn205
Copy link

@Warrenn205 Warrenn205 commented Jan 6, 2025

Description

In this PR, I tackled Issue #55 which was to upgrade the Next.js version from 12.3 to 13.5 in order to
leverage the latest features, optimizations, and improvements.

Related Issue

#55

Type of Change

  • Bug fix: A non-breaking change that fixes an issue.
  • New feature: A non-breaking change that adds functionality.
  • Breaking change: A change that causes existing functionality to not work as expected.
  • Performance improvement: A change that improves performance.

Proposed Solution

In my PR, I upgraded the Next.js version from 12.3 to 13.5. In the package.json, I updated the Next.js dependency variable "next" from "12.3.0" to "13.5.8", then ran npm install in order to install any changes. Following the Next.js Migration Guide provided, I also ran two codemods (next-image-to-legacy-image and next-image-experimental) for safely upgrading the respective imports in order to maintain the same behavior and functionalities previously in Next.js 12.3. I also ensured that all client-side rendering functionalities were working correctly in version 13.5 and optimized the application for improved performance.

How to Test

Run the application from the local development server using the command "npm run dev: all" in the terminal. Test any of the features of the application to ensure that client side rendering functionalities are working as expected.

Unit Tests

  1. Tested the Sign in page for ensuring that users can sign in successfully into application. Originally recieved CSS errors stating that width and height values in the Image tag importing from ImageURL had to be changed from "38.74px" and "auto" to "39" as there were conflicts.
  2. Ensured that the onboarding page works as expected without any issues. I had to change the width and height values in the Image tag importing from ImageURL had to be changed from "38.74px" and "auto" to "39" as there were conflicts there as well.
  3. Tested Chat and History features to ensure that they worked as they did before upgrading to Next.js 13.5.
  4. Tested tools in order to ensure that they still had the same functionalities before upgrading as well.

Documentation Updates

  • No

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Warrenn205 ,
The changes in layouts/AuthLayout/AuthLayout.jsx are mainly formatting and not directly related to the Next.js upgrade. Consider separating these changes into a different PR focused on code cleanup.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will do that. Thank you much Poojith.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in layouts/MainAppLayout/MainAppLayout.jsx are mainly formatting and not directly related to the Next.js upgrade. Consider separating these changes from the Pull request.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. I will resolve this soon. Thank you.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Warrenn205 ,
"@emotion/cache": "^11.14.0",
"@next/codemod": "^15.1.3",

are these dependencies required as part of nextjs upgrade? if yes, please reply back to this thread with brief explanation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants