Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix create-react-admin Vite alias and test #10472

Merged
merged 2 commits into from
Jan 24, 2025
Merged

Fix create-react-admin Vite alias and test #10472

merged 2 commits into from
Jan 24, 2025

Conversation

slax57
Copy link
Contributor

@slax57 slax57 commented Jan 24, 2025

No description provided.

@slax57 slax57 added the RFR Ready For Review label Jan 24, 2025
@slax57 slax57 added this to the 5.5.2 milestone Jan 24, 2025
fireEvent.change(await screen.findByLabelText("Username *"), {
target: { value: "janedoe" },
});
fireEvent.change(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

weird intendation

@@ -33,7 +36,9 @@ test("should pass", async () => {

// Open the first post
fireEvent.click(await screen.findByText("Post 1"));
fireEvent.click(await screen.findByText("Edit"));
fireEvent.click(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same

@slax57 slax57 merged commit 4b19a85 into master Jan 24, 2025
16 checks passed
@slax57 slax57 deleted the fix-cra-vite-alias branch January 24, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants