feat(ra-ui-materialui): Improve FilterButton UX #10183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanMarmelab
changed the title
fzaninotto
requested changes
Sep 5, 2024
| @@ -212,6 +213,16 @@ export const FilterButton = (props: FilterButtonProps) => { | |||
| </MenuItem> | |||
| ) | |||
| )} | |||
| {hasFilterValues && ( | |||
| <Box | |||
| @@ -212,6 +213,16 @@ export const FilterButton = (props: FilterButtonProps) => { | |||
| </MenuItem> | |||
| ) | |||
| )} | |||
| {hasFilterValues && ( | |||
There was a problem hiding this comment.
To not display the divider if we don't have any option below
…le state if applied
|
PR based from the wrong branch. New PR available : #10186 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
There is no way to differentiate between filter choices and filter actions (such as save current query) in the FilterButton
when you select a filter, it disappears from the list, which changes the place of each choice item and makes it hard to remember where is the filter you want to enable ; same for the actions (Remove all filters)
To Do
Additional Checks
masterfor a bugfix, ornextfor a feature- [ ] The documentation is up to date