E2E slice ordering adjustment #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is jsut a bug, thanks for spotting. I do recall an issue about e2e slice ordering, can't find it now but it seems like this may be the solution :) |
marksgraham
approved these changes
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was pointed out to me on a few test files that the converted output had the first slice as last within each volume, and I noticed that the logic utilized for slice ordering
int(chunk.slice_id / 2) - 1becomes -1 ifchunk.slice_idis 0, which was happening with the test E2E files.Are there other files that you've encountered where the
- 1is needed? Removing it seems like a simple solution, but if some files need that last bit of the equation, then there might need to be more logic around whether or not to do the subtraction...