Update E2E acquisition_date to be datetime like the other readers #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All other readers handle acquisition_time as a datetime.datetime object, not a time.struct_time to str.
marksgraham
approved these changes
Aug 5, 2024
|
Makes sense to me! |
|
(Did you mean to merge instead of close?) |
|
ugh sorry, no! merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of the readers currently store acquisition_date as a datetime; E2E storing this as a string makes things a bit sticky for DICOM conversion. The other option would be to switch all of the readers to store these values as strings and change the DICOM metadata part to expect strings.