Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build fails on windows #109

Merged
merged 1 commit into from
Feb 1, 2025
Merged

fix: build fails on windows #109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/honest-apricots-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@marko/run": patch
---

Fix build command failing on Windows
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"lint": "eslint --format unix . && prettier . --check --with-node-modules --log-level=warn",
"prepare": "husky",
"report": "open ./coverage/lcov-report/index.html",
"test": "cross-env NODE_ENV=test NODE_OPTIONS='$NODE_OPTIONS --import tsx' mocha",
"test": "cross-env NODE_ENV=test NODE_OPTIONS=\"$NODE_OPTIONS --import tsx\" mocha",
"test:update": "cross-env UPDATE_EXPECTATIONS=1 npm test -- --update"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/run/src/vite/plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ export default function markoRun(opts: Options = {}): Plugin[] {
},
async resolveId(importee, importer) {
if (importee === "@marko/run/router") {
return path.resolve(root, ROUTER_FILENAME);
return normalizePath(path.resolve(root, ROUTER_FILENAME));
} else if (
importee.endsWith(".marko") &&
importee.includes(relativeEntryFilesDirPosix)
Expand Down