Add source, destination and property stacks in context array #44
Conversation
Toilal
changed the title
| private function push($key, $value, &$context) | ||
| { | ||
| if (!array_key_exists($key, $context)) { | ||
| $stack = []; |
There was a problem hiding this comment.
How do you feel about using an actual stack (e.g. SplStack) instead of an array? I think using SplStack makes more sense for what we're doing here (pushing/popping). But for the end user an array would be more convenient when they are doing something with the context (e.g. all the array_ functions are available to them etc.). So I guess we'd best stick to an array :)
There was a problem hiding this comment.
I think we should stick on array too. Maybe I could extract push/pop private methods into a utility class though (in the middlareware pull request, those are duplicated)
|
I'm merging this, but I'm gonna wait with tagging a new release until I've been through all the PR's. So this is gonna sit on master for a while. Anyways, thanks for your contribution! |
This brings additionnal data into context, source stack, destination stack and property stack.
Those context data could be used in custom operation or custom mappers provide more context of the object graph that is currently converted.
It could also help to implement some feature requests like #36, #16, #14 ...