Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove void return type for propertyDiff() #189

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Remove void return type for propertyDiff() #189

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b66e04e
Remove void return in array from onePropertyDiff
rishabh-prodigal Oct 24, 2022
117c1c2
Add tests and update return type
rishabh-prodigal Oct 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/api/tsOut_model.js.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,8 @@ <h1 class="page-title">tsOut/model.js</h1>
propertyDiff(key) {
// TODO: determine if returning an array is really the best option
if (key) {
return [this.onePropertyDiff(key)];
const diff = this.onePropertyDiff(key);
return diff ? [diff] : [];
}
else {
const diffResult = [];
Expand Down
3 changes: 2 additions & 1 deletion ts/model.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,8 @@ abstract class NohmModel<TProps extends IDictionary = IDictionary> {
): Array<void | IPropertyDiff<keyof TProps>> {
rak3n marked this conversation as resolved.
Show resolved Hide resolved
// TODO: determine if returning an array is really the best option
if (key) {
return [this.onePropertyDiff(key)];
const diff = this.onePropertyDiff(key);
return diff ? [diff] : [];
} else {
const diffResult: Array<IPropertyDiff<keyof TProps>> = [];
for (const [iterationKey] of this.properties) {
Expand Down