Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .npmignore #22

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create .npmignore #22

wants to merge 1 commit into from

Conversation

eugenelim
Copy link

Remove test/ folder from being published with the npm package

Remove test/ folder from being published with the npm package
@maritz
Copy link
Owner

maritz commented Feb 15, 2018

Any specific reason you want to use this deprecated module still?

I'm not opposed to your change itself, I just don't thing it's actually needed.

@eugenelim
Copy link
Author

we have locked down dependencies for our project release, and I am working on reducing the files pulled down by npm to reduce our deploy time.

@maritz
Copy link
Owner

maritz commented Feb 15, 2018

Okay, but if dependencies are locked down, how is changing a dependency version gonna work? If you can change to the other package, I strongly advise you to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants