Merged PR 34167: Do not mmap files for conversion in Quicksand API

* Do not mmap files for conversion
marian-nmt · Apr 23, 2024 · 07042cf · 07042cf
1 parent 2745b77
commit 07042cf
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -40,6 +40,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - New experimental layer framework for Transformer-like models.
 
 ### Fixed
+- Do not mmap files for conversion via Quicksand API
 - Fixed ALiBI states and caching in new layer framework
 - Throw exception when forcing with FS vocabs
 - Fixed force-decoding with LSH

diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-v1.12.29
+v1.12.30
diff --git a/src/microsoft/quicksand.cpp b/src/microsoft/quicksand.cpp
@@ -303,7 +303,7 @@ DecoderCpuAvxVersion parseCpuAvxVersion(std::string name) {
 bool convertModel(std::string inputFile, std::string outputFile, int32_t targetPrec, int32_t lshNBits) {
   std::cerr << "Converting from: " << inputFile << ", to: " << outputFile << ", precision: " << targetPrec << std::endl;
 
-  auto modelFile = New<marian::io::ModelWeights>(inputFile);
+  auto modelFile = New<marian::io::ModelWeights>(inputFile, marian::io::MmapMode::DontMmap);
 
   YAML::Node config = modelFile->getYamlFromModel();
   std::stringstream configStr;