Skip to content

Commit

Permalink
fix(build): simplify rn-worklets-core setup (#287)
Browse files Browse the repository at this point in the history
With the latest version of RN Worklets Core you can use it on old and
new arch. Before you had to install specific versions for each arch.
  • Loading branch information
hannojg authored Jan 5, 2025
1 parent 69d295b commit 5c77764
Show file tree
Hide file tree
Showing 11 changed files with 940 additions and 520 deletions.
26 changes: 3 additions & 23 deletions docs/docs/guides/GETTING_STARTED.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -18,29 +18,9 @@ npm i react-native-filament

2. `react-native-filament` depends on [`react-native-worklets-core`](https://github.com/margelo/react-native-worklets-core):

<Tabs
groupId="rnwcInstallation"
defaultValue="old_arch"
values={[
{label: 'Old Arch', value: 'old_arch'},
{label: 'New arch', value: 'new_arch'}
]}>
<TabItem value="old_arch">
```sh
npm i react-native-worklets-core
```

</TabItem>

<TabItem value="new_arch">
On the new arch you need to use the beta version of `react-native-worklets-core`:

```sh
npm i react-native-worklets-core@beta
```

</TabItem>
</Tabs>
```sh
npm i react-native-worklets-core
```

For react-native-worklets-core its necessary to add a plugin to your `babel.config.js` as well:

Expand Down
286 changes: 143 additions & 143 deletions package/example/AppExampleFabric/ios/Podfile.lock

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@
"$(inherited)",
" ",
);
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
REACT_NATIVE_PATH = "${PODS_ROOT}/../../../../node_modules/react-native";
SDKROOT = iphoneos;
SWIFT_ACTIVE_COMPILATION_CONDITIONS = "$(inherited) DEBUG";
USE_HERMES = true;
Expand Down Expand Up @@ -680,7 +680,7 @@
"$(inherited)",
" ",
);
REACT_NATIVE_PATH = "${PODS_ROOT}/../../node_modules/react-native";
REACT_NATIVE_PATH = "${PODS_ROOT}/../../../../node_modules/react-native";
SDKROOT = iphoneos;
USE_HERMES = true;
VALIDATE_PRODUCT = YES;
Expand Down
2 changes: 1 addition & 1 deletion package/example/AppExampleFabric/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"react-native-safe-area-context": "^4.11.0",
"react-native-screens": "^3.34.0",
"react-native-video": "^6.6.4",
"react-native-worklets-core": "^2.0.0-beta.4",
"react-native-worklets-core": "^1.5.0",
"rn-fetch-blob": "^0.12.0",
"shared": "workspace:^"
},
Expand Down
4 changes: 2 additions & 2 deletions package/example/AppExamplePaper/Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,8 @@ PLATFORMS
ruby

DEPENDENCIES
activesupport (>= 6.1.7.5, < 7.1.0)
cocoapods (>= 1.13, < 1.15)
activesupport (>= 6.1.7.5, != 7.1.0)
cocoapods (>= 1.13, != 1.15.1, != 1.15.0)

RUBY VERSION
ruby 2.6.10p210
Expand Down
Loading

0 comments on commit 5c77764

Please sign in to comment.