Handle invalid ticketState and add new test.

marcosuma · Feb 19, 2023 · b2867ac · b2867ac
1 parent 528db9d
commit b2867ac
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/web/controllers/__tests__/reports.controller.test.js b/web/controllers/__tests__/reports.controller.test.js
@@ -13,7 +13,10 @@ require("dotenv").config();
 describe("Controller", () => {
   const mockResponse = () => {
     const res = {};
-    res.status = jest.fn().mockReturnValue(res);
+    res.status = jest.fn().mockImplementation((code) => {
+      res.code = code;
+      return res;
+    });
     res.send = jest.fn().mockReturnValue(res);
     res.json = jest.fn().mockReturnValue(res);
     return res;
@@ -72,4 +75,16 @@ describe("Controller", () => {
 
     expect(ReportModel.getReports).toBeCalled();
   });
+
+  it("it returns 400 when ticketState is invalid", async () => {
+    res = await controller.updateReport(
+      {
+        params: { reportId: "mock-id" },
+        body: { ticketState: "WRONG_REQUEST" },
+      },
+      mockResponse()
+    );
+
+    expect(res.code).toBe(400);
+  });
 });
diff --git a/web/controllers/reports.controller.js b/web/controllers/reports.controller.js
@@ -48,6 +48,9 @@ const UPDATE_HANDLER = {
 };
 
 exports.updateReport = (req, res) => {
+  if (UPDATE_HANDLER[req.body.ticketState] === undefined) {
+    return res.status(400).send();
+  }
   UPDATE_HANDLER[req.body.ticketState].execute(
     DataModel.getReportModel(),
     req,