Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added human readable JSON output for Device #19

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

lostfields
Copy link
Contributor

Human readable device information, instead of displaying enum values it will output enum key when JSON serializing the objects. Device setters also supports enum key.

image

@lostfields
Copy link
Contributor Author

Earlier, JSON.stringify(groups) outputted

[{
  "_id":8440,
  "_name":"My House",
  "_devices":[{"_guid":"***","_name":"***","_operate":1,"_operationMode":3,"_temperatureSet":21,"_fanSpeed":0,"_fanAutoMode":3,"_airSwingLR":2,"_airSwingUD":2,"_ecoMode":0,"_actualNanoe":0,"_ecoNavi":0,"_nanoe":1,"_iAuto":0,"_airDirection":0,"_ecoFunctionData":0,"_insideTemperature":0,"_outTemperature":0,"lastSettingMode":0}]
}]

and now

[{
  "id":8440,
  "name":"My House",
  "devices":[{"guid":"***","name":"***","operate":"On","operationMode":"Heat","temperatureSet":21,"fanSpeed":"Auto","fanAutoMode":"AirSwingLR","airSwingLR":"Mid","airSwingUD":"Mid","ecoMode":"Auto","ecoNavi":0,"nanoe":"Off","iAuto":0,"actualNanoe":0,"airDirection":0,"ecoFunctionData":0,"insideTemperature":0,"outTemperature":0}]
}]

That may be a breaking change, it depends. Although it's more correct to do it this way since the serialized value is the same as the class definition.

lostfields and others added 2 commits January 3, 2025 20:48
…-readable-device

chore/Backward compatible json output for human readable device
@lostfields
Copy link
Contributor Author

I've made it backwards compatible now, it will output the same as before with no breaking changes. To get the new output you have to set ComfortCloudClient.outputMode = 'pretty'

What do you think @marc2016 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant