-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added human readable JSON output for Device #19
Open
lostfields
wants to merge
9
commits into
marc2016:master
Choose a base branch
from
lostfields:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added human readable JSON output for Device
Earlier, [{
"_id":8440,
"_name":"My House",
"_devices":[{"_guid":"***","_name":"***","_operate":1,"_operationMode":3,"_temperatureSet":21,"_fanSpeed":0,"_fanAutoMode":3,"_airSwingLR":2,"_airSwingUD":2,"_ecoMode":0,"_actualNanoe":0,"_ecoNavi":0,"_nanoe":1,"_iAuto":0,"_airDirection":0,"_ecoFunctionData":0,"_insideTemperature":0,"_outTemperature":0,"lastSettingMode":0}]
}] and now [{
"id":8440,
"name":"My House",
"devices":[{"guid":"***","name":"***","operate":"On","operationMode":"Heat","temperatureSet":21,"fanSpeed":"Auto","fanAutoMode":"AirSwingLR","airSwingLR":"Mid","airSwingUD":"Mid","ecoMode":"Auto","ecoNavi":0,"nanoe":"Off","iAuto":0,"actualNanoe":0,"airDirection":0,"ecoFunctionData":0,"insideTemperature":0,"outTemperature":0}]
}] That may be a breaking change, it depends. Although it's more correct to do it this way since the serialized value is the same as the class definition. |
…-readable-device chore/Backward compatible json output for human readable device
I've made it backwards compatible now, it will output the same as before with no breaking changes. To get the new output you have to set What do you think @marc2016 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Human readable device information, instead of displaying enum values it will output enum key when JSON serializing the objects. Device setters also supports enum key.