Make sure truncated text ends with a newline character #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the SSSOM text needs to be truncated because it contains more than 1,000 lines, the truncated text by default will not end with a newline character, which will make `tsvalid` unhappy. So we need to forcefully append a newline character after the truncation.
matentzn
approved these changes
Dec 10, 2024
|
Much appreciated to digging through that code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the SSSOM text needs to be truncated because it contains more than 1,000 lines, the truncated text by default will not end with a newline character, which will make
tsvalidunhappy. So we need to forcefully append a newline character after the truncation.