add qaseprite install step to packages.yml

[dogboydog]

Fix #4109

Build and bundle qaseprite plugin with Tiled

• Linux (AppImage)
• Linux (Snap)
• MacOS
• Windows

[bjorn]

Two small comments. Overall, I think we can wait a bit with merging this until we have tried adding it for other platforms as well.

[bjorn]

The macOS build failure is a recent breakage in the workflow, which I'm trying to address in #4124 now.

[dogboydog]

This build worked for me on macOS Sonoma (x86)
https://github.com/dogboydog/tiled/actions/runs/12450020727

[bjorn]

Hmm, for both versions I get this on Sequoia 15.1:

Not sure yet what the issue is, I don't get any additional output when running from a terminal. My first guess would be some missing library, but I couldn't find any. I also tried removing the Contents/PlugIns/imageformats/libqaseprite.dylib file, but Tiled still wouldn't launch.

[dogboydog]

I have this problem all the time on mac (including with the Tiled builds I tested). I have to do this:

xattr -r -d com.apple.quarantine Tiled.app

[bjorn]

I have this problem all the time on mac (including with the Tiled builds I tested).

Ah, of course, since these builds are from the pull request, they're not signed and notarized. Boy, what a strangely misleading error message... Indeed, after doing that the builds work and the plugin loads!

[dogboydog]

I agree the error message is not helpful at all, very aggressive how it tells you to send it to the trash lol... I get the same when I try to test my games on a mac

[bjorn]

Alright, snap now compiles with the qaseprite plugin, but it doesn't work because it is likely affected by mapeditor/qaseprite#2.

[bjorn]

Hmm, while this PR adds qaseprite to the GitHub Actions workflow, for the Windows releases we actually need it to compile as part of appveyor.yml.

[bjorn]

Alright, AppVeyor works! Unfortunately the plugin is still not functional in the snap. We can see it sets the environment variable:

:: ++ qmake -query QT_INSTALL_PLUGINS
:: + export QT_PLUGIN_PATH=/usr/lib/x86_64-linux-gnu/qt5/plugins
:: + QT_PLUGIN_PATH=/usr/lib/x86_64-linux-gnu/qt5/plugins
:: + craftctl default
:: + cmake /root/parts/qaseprite/src -G 'Unix Makefiles'

But later on when installing, it goes to the wrong location:

: Install the project...
:: -- Install configuration: "RelWithDebInfo"
:: -- Installing: /root/parts/qaseprite/install/usr/lib/plugins/imageformats/libqaseprite.so

This is the same location as where it used to go before, so it appears the QT_PLUGIN_PATH environment variable might not be getting through to the CMake configure step.

[dogboydog]

I found this
https://forum.snapcraft.io/t/does-setting-environment-variables-work-with-override-build/5517

I’m afraid snapcraftctl doesn’t quite work this way, nor was it designed to. 

When you run snapcraftctl build, snapcraftctl isn’t the utility actually building, it’s still the parent snapcraft CLI, which is running under its own environment. When you call snapcraftctl build, you’re literally saying “please run the build exactly as you would have otherwise”.

If you need to customize the build process to this extend, you’ll need to completely override it in the scriptlet, or implement a plugin that exports the proper environment for the build process.

Maybe the same applies to the cmake plugin.

Could be that we could use cmake-parameters instead , but not with the output of a command like qmake -query QT_INSTALL_PLUGINS 🤔 Would likely need to be hard coded I think if you went that way
https://canonical-snapcraft.readthedocs-hosted.com/en/latest/common/craft-parts/reference/plugins/cmake_plugin/