Adding support for list property types #4002
Conversation
|
Urgh, turned out the "Ability to add items to a list" is only mostly working. When just pressing the "+ Add" button instead of using the menu, it is not possible to add items of the same custom enum or class type. This is because the values are at that point converted to their "display value", which means a class is just a map and an enum is just a number, and only the |
src/tiled/varianteditorfactory.cpp
Outdated
| @@ -196,12 +203,14 @@ QWidget *VariantEditorFactory::createEditor(QtVariantPropertyManager *manager, | |||
| if (!editor) | |||
| editor = QtVariantEditorFactory::createEditor(manager, property, parent); | |||
|
|
|||
| if (type == QMetaType::QColor || type == VariantPropertyManager::displayObjectRefTypeId() || property->isModified()) { | |||
| if (true || type == QMetaType::QColor || type == VariantPropertyManager::displayObjectRefTypeId() || property->isModified()) { | |||
There was a problem hiding this comment.
Problem here is the if (true of course. It should be replaced with a check on whether the property is a value in a list (so whether its parent is a list property). Unfortunately, we don't have access to the parent property (they're private, and in theory there could even be multiple in this properties framework).
If we find a way to make this work, it should of course also only determine the visibility of the "Delete" button, and not affect the visibility of the "Reset" button.
* Added 'list' as option when adding properties, based on QVariantList. * Added support for saving and loading list properties to TMX and JSON formats.
The ListEdit features a button to add an item to the list (currently just adds "0" integer values).
* There is now menu alongside the menu to add new values:
- Choosing from the menu adds a value of the selected type
- Clicking the button now adds the same type as the last item, or
spawns the menu (for empty lists)
* Saving in JSON format now supports lists of lists (not yet supported
for loading)
* Some code moved around to share code between AddValueProperty and the
new menu for adding list items.
Also switched from "value" to "item" elements.
bjorn
force-pushed
the
list-properties
branch
from
6f0a900 to
334deed
Compare
|
Resuming work on this based on the new Properties framework introduced in #4045, I've just rebased the changes. The code for actually displaying the list will have to be re-written, so for now it just displays the amount of items:
|
Implementation so far:
QVariantList.CustomPropertiesHelperto create sub-properties that display the values in the list (maybe should rather be done by theVariantPropertyManager).VariantPropertyManagerbecause it couldn't delegate class member creation back to theCustomPropertiesHelper. IfVariantPropertyManagershould handle lists, then it would need to handle classes as well.ToDo:
Resolves #1493