Fix Xcode 16 compilation (#2323)

Co-authored-by: Aleksei Sapitskii <[email protected]>

.fastlane/Fastfile

@@ -27,15 +27,15 @@ platform :ios do
       team_id: "GJZR2MEM28", # Developer Portal Team ID,
       profile_name: lane_context[SharedValues::MATCH_PROVISIONING_PROFILE_MAPPING]["mapbox.ExamplesUITests.xctrunner"],
       targets: ["ExamplesUITests"],
-      code_sign_identity: "Apple Development: Machiney McMachineface",
+      code_sign_identity: "Apple Development: Created via API",
     )
     update_code_signing_settings(
       use_automatic_signing: false,
       path: "Apps/Examples/Examples.xcodeproj",
       team_id: "GJZR2MEM28", # Developer Portal Team ID,
       profile_name: lane_context[SharedValues::MATCH_PROVISIONING_PROFILE_MAPPING]["com.mapbox.examples"],
       targets: ["Examples"],
-      code_sign_identity: "Apple Development: Machiney McMachineface",
+      code_sign_identity: "Apple Development: Created via API",
     )
     run_tests(
       workspace: 'Apps/Apps.xcworkspace',
@@ -95,7 +95,7 @@ platform :ios do
       team_id: "GJZR2MEM28", # Developer Portal Team ID,
       profile_name: lane_context[SharedValues::MATCH_PROVISIONING_PROFILE_MAPPING]["com.mapbox.examples"],
       targets: ["Examples"],
-      code_sign_identity: "Apple Development: Machiney McMachineface",
+      code_sign_identity: "Apple Development: Created via API",
       entitlements_file_path: "Examples/Examples_CarPlay.entitlements"
     )
     sync_code_signing(type: "appstore")
@@ -114,7 +114,7 @@ platform :ios do
 
   lane :build_tests do
     sh("cd .. && xcodegen")
-    app_store_connect_api_key # Generate API Token
+    # app_store_connect_api_key # Generate API Token
     setup_circle_ci
     sync_code_signing(app_identifier: "com.mapbox.MapboxMapsTestHost")
     update_code_signing_settings(
@@ -123,7 +123,7 @@ platform :ios do
       team_id: "GJZR2MEM28", # Developer Portal Team ID,
       profile_name: lane_context[SharedValues::MATCH_PROVISIONING_PROFILE_MAPPING]["com.mapbox.MapboxMapsTestHost"],
       targets: ["MapboxTestHost"],
-      code_sign_identity: "Apple Development: Machiney McMachineface",
+      code_sign_identity: "Apple Development: Created via API",
     )
     run_tests(
       project: 'MapboxMaps.xcodeproj',

Sources/.swiftlint.yml

@@ -3,3 +3,4 @@ opt_in_rules:
   - missing_docs
 disabled_rules:
   - file_length
+  - non_optional_string_data_conversion

Sources/MapboxMaps/Annotations/ViewAnnotationManager.swift

@@ -76,9 +76,10 @@ public final class ViewAnnotationManager {
     /// The complete list of annotations associated with the receiver.
     @available(*, deprecated, message: "Use ViewAnnotation")
     public var annotations: [UIView: ViewAnnotationOptions] {
-        idsByView.compactMapValues { [mapboxMap] id in
+        let values = idsByView.compactMapValues { [mapboxMap] id in
             try? mapboxMap.options(forViewAnnotationWithId: id)
         }
+        return values
     }
 
     internal init(containerView: UIView, mapboxMap: MapboxMapProtocol, displayLink: Signal<Void>) {

Tests/.swiftlint.yml

@@ -5,3 +5,5 @@ disabled_rules:
   - type_body_length
   - file_length
   - function_body_length
+  - non_optional_string_data_conversion
+  - static_over_final_class

Tests/MapboxMapsTests/Foundation/Extensions/Turf/GeometryTests.swift

@@ -147,7 +147,7 @@ final class GeometryTests: XCTestCase {
                        expectedTurfMultiPolygon.coordinates)
     }
 
-    // // MARK: - Turf Geometry → Geometry
+    // MARK: - Turf Geometry → Geometry
     func testGeometryToMBXGeometry_Point() {
         // Given
         let point = Point(CLLocationCoordinate2D(latitude: -10, longitude: 10))