Fix memory leak in navigation example (#2139)

mapbox · May 7, 2024 · 121922b · 121922b
1 parent ce0d53a
commit 121922b
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/Apps/Examples/Examples/All Examples/NavigationSimulator.swift b/Apps/Examples/Examples/All Examples/NavigationSimulator.swift
@@ -38,10 +38,14 @@ final class NavigationSimulator {
         isStarted = true
 
         viewport.transition(to: followPuckViewPortState) { _ in
-            Timer.scheduledTimer(withTimeInterval: 1, repeats: true) { timer in
-                if !self.routePointsToTravel.isEmpty {
+            Timer.scheduledTimer(withTimeInterval: 1, repeats: true) { [weak self] timer in
+                guard let self else {
+                    return timer.invalidate()
+                }
+
+                if !routePointsToTravel.isEmpty {
                     let nextPoint = self.routePointsToTravel.removeFirst()
-                    self.currentLocation = nextPoint
+                    currentLocation = nextPoint
                 } else {
                     // Journey completed.
                     timer.invalidate()

diff --git a/Tests/ExamplesTests/TestableExampleTests.swift b/Tests/ExamplesTests/TestableExampleTests.swift
@@ -3,7 +3,7 @@ import ObjectiveC.runtime
 @testable import Examples
 import MapboxMaps
 
-class TestableExampleTests: XCTestCase {
+final class TestableExampleTests: XCTestCase {
     private var example: Example?
     private weak var weakExampleViewController: UIViewController?
     private weak var weakMapView: MapView?