You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The stylesheet currently hardcodes the names of abstract classes in the iOS map SDK in order to gloss them with “(Abstract Class)”. It would be awkward for another library like MapboxGeocoder.swift or MapboxDirections.swift to adopt this stylesheet; we’d need to add those libraries’ abstract classes, which could get out of control fast.
Ideally we’d find a way to insert that gloss as plain text instead of as CSS generated content, but at the least, we should factor out this list of abstract classes. SCSS allows for variables; it might also be possible to specify the variables at compile time.
The stylesheet currently hardcodes the names of abstract classes in the iOS map SDK in order to gloss them with “(Abstract Class)”. It would be awkward for another library like MapboxGeocoder.swift or MapboxDirections.swift to adopt this stylesheet; we’d need to add those libraries’ abstract classes, which could get out of control fast.
Ideally we’d find a way to insert that gloss as plain text instead of as CSS generated content, but at the least, we should factor out this list of abstract classes. SCSS allows for variables; it might also be possible to specify the variables at compile time.
jazzy-theme/assets/css/jazzy.css.scss
Lines 387 to 394 in 22c2eda
/ref mapbox/mapbox-gl-native#7478
/cc @friedbunny @captainbarbosa
The text was updated successfully, but these errors were encountered: