Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stylesheet hardcodes abstract class names #2

Open
1ec5 opened this issue Jan 31, 2019 · 0 comments
Open

Stylesheet hardcodes abstract class names #2

1ec5 opened this issue Jan 31, 2019 · 0 comments

Comments

@1ec5
Copy link

1ec5 commented Jan 31, 2019

The stylesheet currently hardcodes the names of abstract classes in the iOS map SDK in order to gloss them with “(Abstract Class)”. It would be awkward for another library like MapboxGeocoder.swift or MapboxDirections.swift to adopt this stylesheet; we’d need to add those libraries’ abstract classes, which could get out of control fast.

Ideally we’d find a way to insert that gloss as plain text instead of as CSS generated content, but at the least, we should factor out this list of abstract classes. SCSS allows for variables; it might also be possible to specify the variables at compile time.

.nav-group-task[data-name="MGLForegroundStyleLayer"],
.nav-group-task[data-name="MGLMultiPoint"],
.nav-group-task[data-name="MGLShape"],
.nav-group-task[data-name="MGLSource"],
.nav-group-task[data-name="MGLStyleFunction"],
.nav-group-task[data-name="MGLStyleLayer"],
.nav-group-task[data-name="MGLTileSource"],
.nav-group-task[data-name="MGLVectorStyleLayer"] {

/ref mapbox/mapbox-gl-native#7478
/cc @friedbunny @captainbarbosa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant