Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate jazzy docset to shared Mapbox theme #2842

Closed
1ec5 opened this issue Mar 1, 2021 · 2 comments
Closed

Migrate jazzy docset to shared Mapbox theme #2842

1ec5 opened this issue Mar 1, 2021 · 2 comments
Labels
archived Archived issue. build Issues related to builds and dependency management. documentation topic: documentation

Comments

@1ec5
Copy link
Contributor

1ec5 commented Mar 1, 2021

This repository currently defines its own theme that’s very similar to the map SDK theme. We should pull in mapbox/jazzy-theme instead of vendoring the theme to take advantage of a number of improvements in that shared theme, such as inline search and styling of deprecated methods (originally from mapbox/mapbox-gl-native#13827, so that we don’t have to remove documentation when deprecating a method).

The shared theme does have some map SDK–specific aspects. For example, abstract classes are hardcoded (mapbox/jazzy-theme#2), but that just means the navigation SDK’s own abstract classes won’t be called out as such, which wouldn’t be a regression.

/cc @mapbox/navigation-ios @mapbox/docs @julianrex

@1ec5 1ec5 added topic: documentation build Issues related to builds and dependency management. documentation labels Mar 1, 2021
@stale
Copy link

stale bot commented Apr 19, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the archived Archived issue. label Apr 19, 2022
@stale
Copy link

stale bot commented Apr 30, 2022

Stale.

@stale stale bot closed this as completed Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
archived Archived issue. build Issues related to builds and dependency management. documentation topic: documentation
Projects
None yet
Development

No branches or pull requests

1 participant