-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documented some vrad options. #390
Documented some vrad options. #390
Conversation
sp/src/utils/vrad/vrad.cpp
Outdated
@@ -20,7 +20,7 @@ | |||
#include "loadcmdline.h" | |||
#include "byteswap.h" | |||
|
|||
#define ALLOWDEBUGOPTIONS (0 || _DEBUG) | |||
#define ALLOWDEBUGOPTIONS (1 || _DEBUG) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why even enable the debug here? You can already set it to be debug if you compile vrad, under the debug option inside Visual Studio
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because i want (purposely) to have these extra commands enable in a full build Release of Vrad since many commands are useful, for example coring (saves lightmap space in bigger maps)
Also is worth nothing that these extra command gives the final user more options to experiment with lighting in general, so we should enable these by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then the function you want to be none debug only you can just remove it from the #ifdef and make it use the mapbase #ifdef instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, Done.
Code base cleanup
added to vrad "-ultrafast"
Extrapasses commandline
documented-some-vbsp-options
Vrad compressconstant commandline
i mess up this PR i will make a new one, sorry for the inconvenience |
Self explanatory and also cleans up unused code.
PR Checklist
develop
branch OR targets another branch with a specific goal in mind