Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented some vrad options. #390

Conversation

Unusuario2
Copy link

@Unusuario2 Unusuario2 commented Feb 10, 2025

Self explanatory and also cleans up unused code.


PR Checklist

  • My PR follows all guidelines in the CONTRIBUTING.md file
  • My PR targets a develop branch OR targets another branch with a specific goal in mind

@@ -20,7 +20,7 @@
#include "loadcmdline.h"
#include "byteswap.h"

#define ALLOWDEBUGOPTIONS (0 || _DEBUG)
#define ALLOWDEBUGOPTIONS (1 || _DEBUG)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why even enable the debug here? You can already set it to be debug if you compile vrad, under the debug option inside Visual Studio

Copy link
Author

@Unusuario2 Unusuario2 Feb 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because i want (purposely) to have these extra commands enable in a full build Release of Vrad since many commands are useful, for example coring (saves lightmap space in bigger maps)

Also is worth nothing that these extra command gives the final user more options to experiment with lighting in general, so we should enable these by default.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then the function you want to be none debug only you can just remove it from the #ifdef and make it use the mapbase #ifdef instead

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, Done.

@Unusuario2 Unusuario2 changed the base branch from master to develop February 10, 2025 18:53
@Unusuario2
Copy link
Author

i mess up this PR i will make a new one, sorry for the inconvenience

@Unusuario2 Unusuario2 closed this Feb 12, 2025
@Unusuario2 Unusuario2 deleted the documented-some-vrad-options branch February 12, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants