Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New reading scheme for vbsp, vvis, vrad #356

Open
wants to merge 18 commits into
base: develop
Choose a base branch
from

Conversation

Unusuario2
Copy link

@Unusuario2 Unusuario2 commented Jan 12, 2025

(Describe your PR here and then fill out the checklist at the bottom)

This is a PR that aims to make the compile tools more easier to read, both for standart hammer user and hammer++.

Changes:

   New reading scheme:  
      -Green: process done.  
      -Blue: indicates a path.  
      -Purple: indicates a number of a funtion.  
      -Red: process failed.  
      -Cyan: Only for header strings.  
  General:  
        -All the color messages are written in valve custom implementation of color cmd "ColorSpewMessage( SPEW_MESSAGE, &red, "********", );" so it doesnt have an issue with linux users.  
        -All "done (0)" set to green to have a better visualizations.  
        -All the warning and error will be tabulated in the console for easy spot.   
        -Added the date of the build day and the target plataform in the tools headers (Like in source 2)  
        -Fixed some letters not being capital.  
        -Fixed some strings that do not have the "\n"  
        -All the paths now are indicated as +- "blue"  
        -The number that indicates data are in purple.  

Examples:
Stock Hammer (new scheme vbsp)
image
Stock Hammer (old scheme vbsp)
image

Stock Hammer++ (new scheme vbsp)
image
Stock Hammer++ (old scheme vbsp)
image

Stock Hammer++ (new scheme vvis)
image
Stock Hammer++ (old scheme vvis)
image

Stock Hammer++ (new scheme vrad)
image
Stock Hammer++ (old scheme vrad)
image

Does this PR close any issues?

  • (Optional) Insert issue number(s) and any related info here

PR Checklist

  • [x ] My PR follows all guidelines in the CONTRIBUTING.md file
  • [x ] My PR targets a develop branch OR targets another branch with a specific goal in mind

Copy link

@1upD 1upD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this PR targets the branch master but it will need to target develop instead.

I notice a lot of tab spacing changes in the output. Can you walk through the overall thought process of which lines of output should have tabs preceding vs not?

@Unusuario2
Copy link
Author

It looks like this PR targets the branch master but it will need to target develop instead.

I notice a lot of tab spacing changes in the output. Can you walk through the overall thought process of which lines of output should have tabs preceding vs not?

Since standard hammer doesnt support color text, spotting an Error/Warning becomes difficult, so for every Error/Warning that the compilers spells there is going to be an 8 character tabulation for easy spotting. This rule applies for every Error/Warning found in the compilers.

Also for hammer++ users this new format combine with colors makes spotting these things very easy and clear.

@Unusuario2 Unusuario2 changed the base branch from master to develop January 13, 2025 17:09
@Unusuario2
Copy link
Author

this PR should be alright, all the useless files/modifications have been removed

@1upD 1upD self-requested a review January 14, 2025 18:07
@Unusuario2 Unusuario2 closed this Jan 20, 2025
@Unusuario2 Unusuario2 deleted the master branch January 20, 2025 20:04
@Unusuario2 Unusuario2 restored the master branch January 20, 2025 20:04
@Unusuario2 Unusuario2 reopened this Jan 20, 2025
@Unusuario2
Copy link
Author

i closed the PR by accident, sorry

@Unusuario2
Copy link
Author

How should i resolve the conflict in vscript_squirrel.cpp? changing the code to develop?

@Blixibon
Copy link
Member

Blixibon commented Feb 8, 2025

How should i resolve the conflict in vscript_squirrel.cpp? changing the code to develop?

The conflict was caused by the recently merged save/restore rewrite. Since I was responsible for merging that and causing this conflict, I took the initiative to resolve the conflict for you, although I think a number of the messages you changed in that file were removed by the rewrite.

@Unusuario2
Copy link
Author

How should i resolve the conflict in vscript_squirrel.cpp? changing the code to develop?

The conflict was caused by the recently merged save/restore rewrite. Since I was responsible for merging that and causing this conflict, I took the initiative to resolve the conflict for you, although I think a number of the messages you changed in that file were removed by the rewrite.

Okay, i will do a PR adding again the modifications from the overwritten file.

@Unusuario2
Copy link
Author

I checked the "overwritten file" and all the Error("\t Warning("\t are found in the vscript_squirrel.cpp so it is good to go. Is PR is able to merge right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants