-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New reading scheme for vbsp, vvis, vrad #356
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this PR targets the branch master
but it will need to target develop
instead.
I notice a lot of tab spacing changes in the output. Can you walk through the overall thought process of which lines of output should have tabs preceding vs not?
Since standard hammer doesnt support color text, spotting an Error/Warning becomes difficult, so for every Error/Warning that the compilers spells there is going to be an 8 character tabulation for easy spotting. This rule applies for every Error/Warning found in the compilers. Also for hammer++ users this new format combine with colors makes spotting these things very easy and clear. |
this PR should be alright, all the useless files/modifications have been removed |
i closed the PR by accident, sorry |
How should i resolve the conflict in vscript_squirrel.cpp? changing the code to develop? |
The conflict was caused by the recently merged save/restore rewrite. Since I was responsible for merging that and causing this conflict, I took the initiative to resolve the conflict for you, although I think a number of the messages you changed in that file were removed by the rewrite. |
Okay, i will do a PR adding again the modifications from the overwritten file. |
I checked the "overwritten file" and all the Error("\t Warning("\t are found in the vscript_squirrel.cpp so it is good to go. Is PR is able to merge right now. |
(Describe your PR here and then fill out the checklist at the bottom)
This is a PR that aims to make the compile tools more easier to read, both for standart hammer user and hammer++.
Changes:
Examples:
Stock Hammer (new scheme vbsp)
Stock Hammer (old scheme vbsp)
Stock Hammer++ (new scheme vbsp)
Stock Hammer++ (old scheme vbsp)
Stock Hammer++ (new scheme vvis)
Stock Hammer++ (old scheme vvis)
Stock Hammer++ (new scheme vrad)
Stock Hammer++ (old scheme vrad)
Does this PR close any issues?
PR Checklist
develop
branch OR targets another branch with a specific goal in mind