Fix clippy lints

mantono · Jan 18, 2024 · cd41a98 · cd41a98
1 parent 9423836
commit cd41a98
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 10 deletions.
diff --git a/src/args.rs b/src/args.rs
@@ -172,7 +172,6 @@ impl Args {
 
     fn read_sys_envs() -> Result<Vec<Property>, ParsePropertyError> {
         std::env::vars()
-            .into_iter()
             .map(Property::try_from)
             .map(|res| res.map(|prop| prop.with_source(prop::Source::EnvVar)))
             .collect()

diff --git a/src/error.rs b/src/error.rs
@@ -35,7 +35,7 @@ impl Display for FireError {
             FireError::GenericIO(err) => format!("IO error: {err}"),
             FireError::NotAFile(path) => format!("{:?} exists but it is not a file", path.clone()),
             FireError::NoReadPermission(path) => format!("No permission to read file {:?}", path.clone()),
-            FireError::TemplateRendering => format!("Unable to render request from template"),
+            FireError::TemplateRendering => String::from("Unable to render request from template"),
             FireError::TemplateKey(key) => format!("Unable to render request due to missing value for key {key}"),
             FireError::Other(err) => format!("Error: {err}"),
         };

diff --git a/src/prop.rs b/src/prop.rs
@@ -71,7 +71,6 @@ pub fn from_file(path: &Path) -> Result<Vec<Property>, ParsePropertyError> {
 
     content
         .lines()
-        .into_iter()
         .map(Property::from_str)
         .map(|prop| prop.map(|p| p.with_source(source)))
         .collect()

diff --git a/src/template.rs b/src/template.rs
@@ -1,8 +1,6 @@
-use handlebars::RenderError;
 use handlebars::{no_escape, Handlebars};
 use std::collections::HashMap;
 use std::collections::HashSet;
-use termcolor::ColorChoice;
 
 use crate::{prop::Property, templ};
 
@@ -27,11 +25,8 @@ fn resolve_values(
     keys: HashSet<String>,
     vars: HashMap<String, String>,
 ) -> Result<HashMap<String, String>, SubstitutionError> {
-    let diff: HashSet<String> = keys
-        .difference(&vars.clone().into_keys().collect())
-        .into_iter()
-        .map(|x| x.clone())
-        .collect();
+    let diff: HashSet<String> =
+        keys.difference(&vars.clone().into_keys().collect()).cloned().collect();
 
     if diff.is_empty() {
         Ok(vars)