Refactor roi table widget #2509
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samtygier-stfc
force-pushed
the
2378-refactor-roi-table-widget
branch
from
54b2947 to
e04a5b1
Compare
…e_roi() self.table_view.get_row_data() would have given an IndexError if the index was wrong, so existing error checking would never have been reached. Safe to assume that this never gets called with an invalid index.
No rows are created in the constructor
samtygier-stfc
force-pushed
the
2378-refactor-roi-table-widget
branch
from
e04a5b1 to
b632df8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work on #2378
Description
Refactor ROITableWidget
Changes
get_row_data()remove_roi()__init__properties to attributeson_row_changeinto classNeeds rebase after #2506Developer Testing
python -m pytest -vsAcceptance Criteria and Reviewer Testing
python -m pytest -vsDocumentation and Additional Notes