Add subsetsum check #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manishrw
reviewed
Oct 18, 2018
| @@ -0,0 +1,20 @@ | |||
| def isSubsetSum (items, length, summ): | |||
There was a problem hiding this comment.
Please provide the comment stating what does the module/function do. Also, include the doctest in the comments.
Doctest reference - https://docs.python.org/2/library/doctest.html
| if (items[length - 1] > summ): | ||
| return isSubsetSum(items, length - 1, summ); | ||
|
|
||
| return isSubsetSum(items, length - 1, summ) or isSubsetSum(items, length - 1, summ - items[length - 1]) |
There was a problem hiding this comment.
It looks like the code runs in an exponential time. Please try to optimize using Dynamic programming.
|
|
||
| return isSubsetSum(items, length - 1, summ) or isSubsetSum(items, length - 1, summ - items[length - 1]) | ||
|
|
||
| if __name__ == '__main__': |
There was a problem hiding this comment.
Please write the test cases in a separate file under the test directory. Check out other test cases which use the pytest to do the testing.
Pytest documentation - https://docs.pytest.org/en/latest/contents.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3