-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple command line arguments for UDC, Interface, BT alias #5
Conversation
This is too important information to be left out with the debug flag. Also, it doesn't produce a lot of output, so it won't clog the regular log.
Allow the user to specify which udc controller to use. DWC2 / usb-gadget / fe98000.usb is not the only one available.
AA Wireless Dongle and derivatives work by creating a Wi-Fi hotspot by setting values in /etc/hostapd/hostapd.conf and relying on the host system having static interface named "wlan0" and ip "10.0.0.1" Instead of having these values hardcoded, parse hostapd.conf and check the "wlan0" interface for its IPv4 address, and use those. In an upcoming commit, we should become able to specify the interface.
Allow the user to specify which network interface is creating the Wi-Fi hotspot on the host system It defaults to the wlan0, 10.0.0.1 setup of AA Wireless Dongle
Allow the user to rename the BLE advertised name of the host system
Thank you for the PR! I added some cleanup commits but at the final test on the Pi it ended up with panic because wrong |
Thank you for the cleanup commits, I learned some things! And thank you for merging. I was stumped at the I found the reason, it's because on Raspbian (buster, at least),
While on buildroot created systems, it's getting installed on That's a bummer, I wish the Buildroot developers kept the path same like on other distros. I'm not sure I like adding another argument for that, seems too specific, I can certainly keep the change local. If I come up with something elegant, I'll submit another PR. |
done in: b2bbf1a |
Oh nice, it was indeed like 4 lines of code, nice usage of default value again. Great, thanks! |
The below patches are complimentary to the awesome work you have done with this repo.
They install:
It is an attempt to stop
aa-proxy-rs
andaawg
from hardcoding a lot of stuff, which should be tunable. Network information is being actively parsed from system.Choosing udc controller may be a minor detail, but it's needed if one needs to use
dummy_hcd
as the controller, and it's better to specify than the default "choose the first one" option.Bear in mind that this is my first time writing anything in Rust/C++, so comments / fixes are welcome.