Feat/warn for dynamic dotnet #2568
Conversation
There was a problem hiding this comment.
I've added some comments inline. Would you review and let me know what you think @v1bh475u? If the proposals work for you, please try them out. If you disagree, let's figure out alternatives.
Signed-off-by: vibhatsu <[email protected]>
Signed-off-by: vibhatsu <[email protected]>
Signed-off-by: vibhatsu <[email protected]>
Signed-off-by: vibhatsu <[email protected]>
|
@williballenthin I have made the changes as we had discussed. Please review them whenever you are free. |
| def find_file_limitations_from_cli(args, rules: RuleSet, file_extractors: list[FeatureExtractor]) -> bool: | ||
| def find_static_limitations_from_cli(args, rules: RuleSet, file_extractors: list[FeatureExtractor]) -> bool: |
There was a problem hiding this comment.
one thing we're losing in the changes is the documentation/naming that makes clear that the static limitations are derived from file extractors (like pefile) not full disassembly-derived extractors (like vivisect). they should be lightweight. so lets find the right place to re-add this documentation.
There was a problem hiding this comment.
Can you please give some more insights?
capa/main.py
Outdated
| args: | ||
| args: The parsed command line arguments from `install_common_args`. | ||
|
|
||
| Handles dynamic dotnet samples. |
There was a problem hiding this comment.
| Handles dynamic dotnet samples. | |
| For example, notifies when handling .NET samples in a sandbox, which may rely on different API patterns. |
There was a problem hiding this comment.
please put explanations before the args/returns/raises blocks.
…comments Signed-off-by: vibhatsu <[email protected]>
Signed-off-by: vibhatsu <[email protected]>
closes #1864
Checklist