Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

web: don't include preview data and options in release mode #2301

Merged
merged 20 commits into from
Aug 21, 2024
Merged

web: don't include preview data and options in release mode #2301

merged 20 commits into from
Aug 21, 2024

Conversation

fariss
Copy link
Collaborator

@fariss fariss commented Aug 19, 2024 •
edited
Loading

closes #2285
closes #2259

This PR -

  • disables the preview data buttons from being displayed and excludes the test files from the build and release.
  • bumps the number of matches in dynamic to 300 instead of 1 (still slow, but manageable)
  • extend rdoc query param to support loading remote .gz files.
  • refactors parseRules used to parse the rdoc rules.

Please preview this PR here: https://s-ff.github.io/capa/explorer

Checklist

  • No CHANGELOG update needed
  • No new tests needed
  • No documentation update needed

@fariss fariss added gsoc Work related to Google Summer of Code project. webui related to capa results web visualization labels Aug 19, 2024
@fariss fariss requested a review from mr-tz August 19, 2024 14:02
@fariss fariss requested a review from williballenthin August 19, 2024 15:27
mr-tz
mr-tz approved these changes Aug 21, 2024
View reviewed changes
Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, just two minor items here but no stoppers

web/explorer/src/components/NavBar.vue Show resolved Hide resolved
web/explorer/src/components/RuleMatchesTable.vue Outdated Show resolved Hide resolved
@fariss @mr-tz
update code comment
980814f 
Co-authored-by: Moritz <[email protected]>
@fariss fariss merged commit c3f24c2 into mandiant:master Aug 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@williballenthin williballenthin williballenthin left review comments

@mr-tz mr-tz mr-tz approved these changes

Assignees
No one assigned
Labels
gsoc Work related to Google Summer of Code project. webui related to capa results web visualization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

webui: dynamic preview button does not work web ui: don't include result document within standalone bundle
3 participants
@fariss @williballenthin @mr-tz