Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dotnet limitation rule for dynamic samples #983

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

v1bh475u
Copy link
Contributor

@v1bh475u v1bh475u commented Jan 21, 2025

needed for issue mandiant/capa#1864

  • move rules from internal/limitation/file to internal/limitation/static
  • add new namespace for dynamic limitations internal/limitation/dynamic
  • add new rule internal-dotnet-file-limitation.yml inside internal/limitation/dynamic namespace

@williballenthin
Copy link
Collaborator

please address pending suggestions, then i'll approve and merge

@v1bh475u
Copy link
Contributor Author

v1bh475u commented Feb 3, 2025

I am sorry. I didn't get it.

@v1bh475u
Copy link
Contributor Author

v1bh475u commented Feb 4, 2025

@williballenthin, I have updated what changes are to be made for the mandiant/capa#2568 to work as intended.

Copy link
Collaborator

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry these suggestions were only pending, but i thought they were visible to you. my mistake.

@williballenthin williballenthin mentioned this pull request Feb 4, 2025
27 tasks
@v1bh475u
Copy link
Contributor Author

v1bh475u commented Feb 4, 2025

Done with changes.

Copy link
Collaborator

@williballenthin williballenthin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@williballenthin williballenthin merged commit cfd394d into mandiant:master Feb 4, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants