Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retries on webhook failure #92

Merged
merged 9 commits into from
Dec 20, 2024
+106 −31
Merged

Add retries on webhook failure #92

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7ac489d
feat: add webhook.retries option
m4rii0 Dec 18, 2024
e7a38e1
feat: adding retry on failure
m4rii0 Dec 18, 2024
3936697
docs: update docs with the new available flag
m4rii0 Dec 18, 2024
8b1f6b4
feat: using hashicrop/retryablehttp library
m4rii0 Dec 19, 2024
4f9084d
chore: disable false positive on magic number in linting
m4rii0 Dec 19, 2024
bf4a487
chore: setting back error type to private
m4rii0 Dec 19, 2024
a35d5f4
feat: Add test for retryable calls, remove unusable code
maksim-paskal Dec 19, 2024
7b03888
feat: Check not retryable status codes
maksim-paskal Dec 19, 2024
223249c
fix: Typo
maksim-paskal Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: disable false positive on magic number in linting
@m4rii0
m4rii0 committed Dec 19, 2024
commit 4f9084d81ca34c6087b2f1a48cf3e8b059b0e78e
2 changes: 1 addition & 1 deletion pkg/config/config.go
View file
Original file line number Diff line number Diff line change
@@ -101,7 +101,7 @@ var config = Type{
WebHookTemplateFile: flag.String("webhook.template-file", os.Getenv("WEBHOOK_TEMPLATE_FILE"), "path to request body template file"),
WebhookInsecure: flag.Bool("webhook.insecureSkip", true, "skip tls verification for webhook"),
WebhookProxy: flag.String("webhook.http-proxy", os.Getenv("WEBHOOK_HTTP_PROXY"), "use http proxy for webhook"),
WebhookRetries: flag.Int("webhook.retries", 3, "number of retries for webhook"),
WebhookRetries: flag.Int("webhook.retries", 3, "number of retries for webhook"), //nolint:mnd
SentryDSN: flag.String("sentry.dsn", "", "sentry DSN"),
WebHTTPAddress: flag.String("web.address", ":17923", ""),
TaintNode: flag.Bool("taint.node", false, "Taint the node before cordon and draining"),