refactor e2e tests #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maksim-paskal
force-pushed
the
refactor-events
branch
from
f2a60ee to
f2f710e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #80 +/- ##
==========================================
- Coverage 98.75% 97.94% -0.81%
==========================================
Files 8 9 +1
Lines 240 341 +101
==========================================
+ Hits 237 334 +97
- Misses 2 5 +3
- Partials 1 2 +1 ☔ View full report in Codecov by Sentry. |
maksim-paskal
force-pushed
the
refactor-events
branch
12 times, most recently
from
dd1db28 to
9434838
Compare
maksim-paskal
force-pushed
the
refactor-events
branch
2 times, most recently
from
e593996 to
9ea49b7
Compare
Make more reliable e2e test, use same execution logic, as main process. Separate event receiver from main logic, make unit test for event package. Add new flags: -resource.name this flag will ignore Azure resourcename from node, will wait events from this resource -exitAfterNodeDrain this flag is needed by e2e tests, this flag wil exits from from after drain, default false Signed-off-by: Maksim Paskal <[email protected]>
maksim-paskal
force-pushed
the
refactor-events
branch
from
9ea49b7 to
83ea915
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make more reliable e2e test, use same execution logic, as main process. Separate event receiver from main logic, make unit test for event package.
Add new flags:
-resource.namethis flag will ignore Azure resourcename from node, will wait events from this resource-exitAfterNodeDrainthis flag is needed by e2e tests, this flag wil exits after drain, default false