-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Joe McNally Instagram Challenge Partial Submission #919
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Joe, thanks for sharing and allowing to take a look.
Well done on set up the whole project from scratch yourself instead of using the Acebook node seed like most of us did. It works great.
The approach to loading and displaying photos via urls works ok. I was able to load a jpg as well as a png I found on the web. It didn't work when I tried to load up a public llink to a couple of my own photos I have on google photos though. So it's not clear how I would share my own photos.
Jest is missing from json.packages but once installed the tests run fine and all pass. A newxt step could be to build out the tests for the functionality you built.
Joe McNally
User stories
Bonus: