Exercise completed #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The content of the README that was included in the forked repo was deleted and replaced with a description of my approach to the exercise. So far it only includes the user stories I've derived from the exercise requirements.
Doubling and mocking were used to remove the BirthdayList test spec's dependence on the Birthday class.
Previously the class used a string to represent its date. It now uses an instance of the Time class.
to_s was overriden to return a 'pretty' version of the birthday's date.
The BirthdatList tests were refactored to remove errors occurring with the use of a Time variable to store the date in the Birthday class.
The method currently only passes a test to print nothing if there are no friends stored with birthdays today.
The incorrect doubles were being used in the tests, which were not mocking the birthday class with the date as an instance of Time.
The incorrect doubles were being used in the tests, which were not mocking the birthday class with the date as an instance of Time.
An error in the way I pushed to remote led to the remote and my local copies diverging. This merge fixes that.
birthday_list was missing a require to use the Birthday class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've completed the exercise, although I ended up doing the challenges in the wrong order as I implemented the 'print birthdays today' user story after I'd done the extension challenges about extracting the Birthday class and using mocks.