Merge pull request #4 from mxtommy/master

Add Virtual destroctors to get rid of warnings
mairas · Oct 24, 2019 · f5bc24b · f5bc24b
2 parents 3a86f63 + f19e47d
commit f5bc24b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/src/ReactESP.h b/src/ReactESP.h
@@ -39,6 +39,7 @@ class TimedReaction : public Reaction {
         last_trigger_time = millis();
         enabled = true;
     }
+    virtual ~TimedReaction() {}
     bool operator<(const TimedReaction& other);
     void add();
     void remove();
@@ -59,6 +60,7 @@ struct TriggerTimeCompare
 class DelayReaction : public TimedReaction {
 public:
     DelayReaction(const uint32_t interval, const react_callback callback);
+    virtual ~DelayReaction() {}
     void tick();
 };
 
@@ -73,6 +75,7 @@ class UntimedReaction : public Reaction {
 public:
     UntimedReaction(const react_callback callback)
     : Reaction(callback) {}
+    virtual ~UntimedReaction() {}
     virtual void add();
     virtual void remove();
     virtual void tick() = 0;
@@ -101,6 +104,7 @@ class ISRReaction : public Reaction {
 public:
     ISRReaction(uint32_t pin_number, int mode, const react_callback callback)
     : Reaction(callback), pin_number(pin_number), mode(mode) {}
+    virtual ~ISRReaction() {}
     void add();
     void remove();
     void tick();