Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add custom headers support for emails #35

Merged
merged 3 commits into from
Feb 2, 2024

Conversation

ukby1234
Copy link
Contributor

Looks like the request interceptor doesn't work quite well with dynamic values unless we create a new client for every message. This is to add a custom email headers support with a custom Java annotations.

@vitalii-chornobryvyi
Copy link
Contributor

Also, please add data into:

  • CHANGELOG.md above the line 8 and line 70
  • README.md above the line 79 and line 88

@ukby1234
Copy link
Contributor Author

@vitalii-chornobryvyi-swi added changelog and readme.

@vitalii-chornobryvyi
Copy link
Contributor

@vitalii-chornobryvyi-swi added changelog and readme.

@ukby1234 nice, please fix also my comment regarding wildcard and we can merge this PR

@ukby1234
Copy link
Contributor Author

@vitalii-chornobryvyi-swi hmm I don’t see your comment about wildcard.

@vitalii-chornobryvyi
Copy link
Contributor

@ukby1234 interesting, why the comment is not displayed, anyway it's this one
image

@ukby1234
Copy link
Contributor Author

ukby1234 commented Feb 1, 2024

@vitalii-chornobryvyi-swi fixed imports as well.

@ukby1234
Copy link
Contributor Author

ukby1234 commented Feb 1, 2024

@vitalii-chornobryvyi-swi can you merge this as well? I don't have the permission to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants