-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/14 allow to limit the movement of the camera #52
Merged
maiermic
merged 109 commits into
master
from
feature/14-allow-to-limit-the-movement-of-the-camera
Nov 9, 2022
Merged
Feature/14 allow to limit the movement of the camera #52
maiermic
merged 109 commits into
master
from
feature/14-allow-to-limit-the-movement-of-the-camera
Nov 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all inputs must have the minimum of 0. Hence, 0 might not be a valid initial value.
Integer can still be parsed and are converted back to the same string without decimal places in JavaScript, e.g. String(Number.parseFloat("1")) returns "1" and not "1.0".
Same order as in diagram.
…es are set `get_angle_distance` throws an exception if passed angles is `None`.
Unit tests require/assume no (implicit) default target.
There are checks in place that allow the current angles to be set later.
…update_of_camera_base_speeds_required` Fix typo `od` to `of`
maiermic
deleted the
feature/14-allow-to-limit-the-movement-of-the-camera
branch
November 9, 2022 08:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #14, Resolves #32