feat(pricing): add records_per_type into QuotingMetrics #2680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
changed the title
| @@ -138,7 +138,7 @@ pub struct NodeRecordStore { | |||
| /// The configuration of the store. | |||
| config: NodeRecordStoreConfig, | |||
| /// Main records store remains unchanged for compatibility | |||
| records: HashMap<Key, (NetworkAddress, ValidationType)>, | |||
| records: HashMap<Key, (NetworkAddress, ValidationType, DataTypes)>, | |||
There was a problem hiding this comment.
Would it be possible to ditch ValidationType and instead use the DataTypes to derive it instead? Just a nit pick tbh, will make things a bit cleaner and can be a follow up if sounds reasonable to you..
There was a problem hiding this comment.
ValidationType also need to hold the content_hash for non-chunk data.
Meanwhile, DataTypes are public API which supposed to keep as simple as possible.
So, don't think merge them is good to the public user.
There was a problem hiding this comment.
Ah sorry, overlooked that! Thanks!
RolandSherwin
approved these changes
Jan 30, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add records_per_type into QuotingMetrics