fix(network): consider MultiAddrNotSupported as a serioud issu.. #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l addr are private
maqi
reviewed
Jan 14, 2025
| println!("If this was your bootstrap peer, restart your node with a supported multiaddr"); | ||
| } | ||
| // if we can't dial a peer on a given address, we should remove it from the routing table | ||
| there_is_a_serious_issue = true |
There was a problem hiding this comment.
as the default value of all_multiaddr_not_supported is to be true, here actually doing the same? then what's the point to change ?
There was a problem hiding this comment.
We set it to all_multiaddr_not_supported = false below.
Only if the entire Vec<Error> is MultiaddrNotSupported, we really go after this error, else this error is harmless.
maqi
approved these changes
Jan 14, 2025
b-zee
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MultiaddrNotSupportederror for the private addr of the peer every single time.MultiaddrNotSupportederror here should not be a huge concern and we should not remove the peer based on this.MultiaddrNotSupported