feat: remove feat flags #2593
Merged
feat: remove feat flags #2593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grumbach
force-pushed
the
remove_feat_flags
branch
from
314fc09 to
2fff515
Compare
# Conflicts: # ant-cli/Cargo.toml # ant-node/Cargo.toml
|
Interesting. The test that fails here seems to have been enabled by this PR. Apparently it wasn't somehow executing before because of the feat flags used/unused in the workflow? Anyway. The issue here is that two tests run in parallel and both post transactions to the same EVM network at the same time. The ideal fix is to run an EVM network for every test, as tests shouldn't indirectly influence each other's results. However as a quick fix, I will just make a PR that forces these tests to run in serie instead of in parallel. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.