feat: Generic payments groundwork #2066
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE
BREAKING CHANGE: many types gone, replaced by UnsignedTransaction SignedTransaction
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // info!("{id} verifying status of spend number({num:?}): {spend:?} : {status:?}"); | ||
| // match status { | ||
| // SpendStatus::Utxo => { | ||
| // // TODO: with the new spend struct requiring `middle payment` |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note test
grumbach
force-pushed
the
generic_payments_groundwork
branch
from
ad12048 to
6b3bd11
Compare
b-zee
force-pushed
the
generic_payments_groundwork
branch
from
6b3bd11 to
4643330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based upon the Spend refactor PR #1989 so it should be merged after it preferably!!
Please ignore the other commits, all the changes are from this commit:
ad12048