chore(node): [#1999] panic on upnp event GatewayNotFound
#2003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickvandijke
force-pushed
the
1999-node-should-panic-on-upnp-failure
branch
from
e6b0d10 to
a8d1feb
Compare
b-zee
reviewed
Jul 25, 2024
sn_networking/src/event/swarm.rs
Outdated
| @@ -80,6 +80,9 @@ impl SwarmDriver { | |||
| } | |||
| event_string = "upnp_event"; | |||
| info!(?upnp_event, "UPnP event"); | |||
| if let libp2p::upnp::Event::GatewayNotFound = upnp_event { | |||
| panic!("UPnP is not enabled/supported on your gateway. Please rerun without the `--upnp` flag"); | |||
There was a problem hiding this comment.
This should be an error that we bubble up. In that case we could also later do graceful shutdowns of our swarm. sn_networking is a library crate, so we don't want consumers to get panics.
There was a problem hiding this comment.
We can bubble the error up, but it would be by one level and still within the sn_networking lib:
https://github.com/maidsafe/safe_network/blob/main/sn_networking/src/driver.rs#L735-L741
Handling this error gracefully would probably take some refactoring. Not sure if that is worth it. Thoughts?
b-zee
approved these changes
Aug 2, 2024
mickvandijke
force-pushed
the
1999-node-should-panic-on-upnp-failure
branch
2 times, most recently
from
7e2be6c to
ad656e1
Compare
b-zee
approved these changes
Aug 5, 2024
RolandSherwin
force-pushed
the
1999-node-should-panic-on-upnp-failure
branch
from
ad656e1 to
816ef88
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 5, 2024
…upnp-failure chore(node): [#1999] panic on upnp event `GatewayNotFound`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes a node panic on the upnp event
GatewayNotFound. This event only fires when the node runs with the--upnpflag and libp2p couldn't find the upnp gateway to open ports on.Related Issue
Fixes #1999
Type of Change
Please mark the types of changes made in this pull request.
Checklist
Please ensure all of the following tasks have been completed: