refactor: apply nightly clippy lints

sn_cli/src/files/upload.rs

@@ -44,30 +44,27 @@ impl UploadedFile {
                 self.filename
             );
         }
-        let serialized = rmp_serde::to_vec(&(&self.filename, &self.data_map)).map_err(|err| {
-            error!("Failed to serialize UploadedFile");
-            err
-        })?;
+        let serialized =
+            rmp_serde::to_vec(&(&self.filename, &self.data_map)).inspect_err(|_err| {
+                error!("Failed to serialize UploadedFile");
+            })?;
 
-        std::fs::write(&uploaded_file_path, serialized).map_err(|err| {
+        std::fs::write(&uploaded_file_path, serialized).inspect_err(|_err| {
             error!(
                 "Could not write UploadedFile of {:?} to {uploaded_file_path:?}",
                 self.filename
             );
-            err
         })?;
 
         Ok(())
     }
 
     pub fn read(path: &Path) -> Result<Self> {
-        let bytes = std::fs::read(path).map_err(|err| {
+        let bytes = std::fs::read(path).inspect_err(|_err| {
             error!("Error while reading the UploadedFile from {path:?}");
-            err
         })?;
-        let metadata = rmp_serde::from_slice(&bytes).map_err(|err| {
+        let metadata = rmp_serde::from_slice(&bytes).inspect_err(|_err| {
             error!("Error while deserializing UploadedFile for {path:?}");
-            err
         })?;
         Ok(metadata)
     }

sn_client/src/lib.rs

@@ -16,19 +16,19 @@
 //! Here are the key functionalities provided by this crate:
 //!
 //! 1. **Network Communication**: It handles communication with the Safe Network, enabling clients to
-//! send and receive messages from the decentralized nodes that make up the network.
+//!    send and receive messages from the decentralized nodes that make up the network.
 //!
 //! 2. **Data Storage and Retrieval**: to store and retrieve data on the Safe Network.
-//! This includes both private and public data, ensuring privacy and security.
+//!    This includes both private and public data, ensuring privacy and security.
 //!
 //! 3. **Authentication and Access Control**: It provides mechanisms for authenticating users and
-//! managing access to data, ensuring that only authorized users can access sensitive information.
+//!    managing access to data, ensuring that only authorized users can access sensitive information.
 //!
 //! 4. **File Management**: The crate supports operations related to file management, such as uploading,
-//! downloading, and managing files and directories on the Safe Network.
+//!    downloading, and managing files and directories on the Safe Network.
 //!
 //! 5. **Token Management**: It includes functionality for managing Safe Network tokens, which can be
-//! used for various purposes within the network, including paying for storage and services.
+//!    used for various purposes within the network, including paying for storage and services.
 //!
 //! ## Quick links
 //! - [Crates.io](https://crates.io/crates/sn_client)

sn_faucet/src/faucet_server.rs

@@ -65,11 +65,10 @@ use tokio::{fs, io::AsyncWriteExt};
 pub async fn run_faucet_server(client: &Client) -> Result<()> {
     let root_dir = get_faucet_data_dir();
     let wallet = load_account_wallet_or_create_with_mnemonic(&root_dir, None)?;
-    claim_genesis(client, wallet).await.map_err(|err| {
+    claim_genesis(client, wallet).await.inspect_err(|_err| {
         println!("Faucet Server couldn't start as we failed to claim Genesis");
         eprintln!("Faucet Server couldn't start as we failed to claim Genesis");
         error!("Faucet Server couldn't start as we failed to claim Genesis");
-        err
     })?;
 
     #[cfg(feature = "initial-data")]

sn_transfers/src/wallet/wallet_file.rs

@@ -69,7 +69,7 @@ pub(super) fn remove_unconfirmed_spend_requests(
         let spend_hex_name = spend.address().to_hex();
         let spend_file_path = spends_dir.join(&spend_hex_name);
         debug!("Writing spend to: {spend_file_path:?}");
-        fs::write(spend_file_path, &spend.to_bytes())?;
+        fs::write(spend_file_path, spend.to_bytes())?;
     }
 
     let unconfirmed_spend_requests_path = wallet_dir.join(UNCONFIRMED_TX_NAME);