feat(faucet_server): download and upload gutenberger book part by part #1818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maqi
force-pushed
the
upload_book_initially
branch
2 times, most recently
from
aa71a12 to
185b1e8
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| pub(crate) async fn download_book(client: &Client, book_id: u32) -> Result<Vec<u8>> { | ||
| let url = format!("http://www.gutenberg.org/ebooks/{book_id}.txt.utf-8"); |
Check warning
Code scanning / devskim
An HTTP-based URL without TLS was detected. Warning
maqi
force-pushed
the
upload_book_initially
branch
from
185b1e8 to
47e9cad
Compare
maqi
force-pushed
the
upload_book_initially
branch
from
47e9cad to
04a020b
Compare
joshuef
approved these changes
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
download and upload gutenberger book part by part to avoid choking the faucet node.
Related Issue
Fixes #<issue_number> (if applicable).
Type of Change
Please mark the types of changes made in this pull request.