ci: add node-launchpad binary to release process
#1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new TUI for the node manager is a new, separate binary that is being added in to the release process. It will have a Github release. For some reason it seems to have became necessary to explicitly call `rustup target` during the artifacts build process. Without doing it, I was getting build errors on macOS.
jacderida
force-pushed
the
ci-node_launchpad_in_release
branch
from
d1dfd86 to
03cbd64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new TUI for the node manager is a new, separate binary that is being added in to the release process. It will have a Github release.
For some reason it seems to have became necessary to explicitly call
rustup targetduring the artifacts build process. Without doing it, I was getting build errors on macOS.Description
reviewpad:summary